Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Progress] Add format prop and Value component #1355

Merged
merged 10 commits into from
Feb 3, 2025

Conversation

mj12albert
Copy link
Member

@mj12albert mj12albert commented Jan 24, 2025

Demo: https://codesandbox.io/p/sandbox/pensive-ptolemy-v5f6lk

  • format prop works the same as NumberField, pass it to the Root
  • Value will render 20% when value={20} by default. When indeterminate it's an empty node

Part of #961

@mj12albert mj12albert added the component: progress This is the name of the generic UI component, not the React module! label Jan 24, 2025
Copy link

netlify bot commented Jan 24, 2025

Deploy Preview for base-ui ready!

Name Link
🔨 Latest commit 5a2ef32
🔍 Latest deploy log https://app.netlify.com/sites/base-ui/deploys/67a07e6e7bb1e3000861a7c3
😎 Deploy Preview https://deploy-preview-1355--base-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mj12albert mj12albert force-pushed the feat/progress-format-value branch from d010114 to 43563c3 Compare January 24, 2025 15:03
@mj12albert mj12albert force-pushed the feat/progress-format-value branch from 2b9733b to bdc9da1 Compare January 27, 2025 07:50
@mj12albert mj12albert marked this pull request as ready for review January 27, 2025 08:05
Copy link
Contributor

@atomiks atomiks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@mj12albert mj12albert merged commit b6291fe into mui:master Feb 3, 2025
22 checks passed
@mj12albert mj12albert deleted the feat/progress-format-value branch February 3, 2025 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: progress This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants