Implement handshake on serial communication for ESP devices #2433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The RUN button will reboot the attached device. Depending on the speed of the device, the speed of the connected computer, the USB tree and the contents of the boot scripts, this make take some time. Instead od just sending the script to run after some time, we now first wait for the python prompt to appear. This brings a robust RUN behavior.
paulvanharen
changed the title
|
@ntoll Do you know who needs to be pinged to get some of these PRs reviewed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran a classroom using Mu and many ESP devices. In the classroom were about 40 students with different laptops. Running code was troublesome. The behavior when using the RUN button was flaky, and dependent on the precise laptop. Hitting RUN and RUN again gave different results.
What happens is the following:
Inspired by the mpremote tool I implemented a handshake on the serial port for the RUN command.
This works fine in my environment; it provides a robust solution. Please note, the testing has been limited.
Glancing through the issues mentioned here at Github, the following issues appear to be similar and may be affected (solved?): #2397, #2319, #1996 and #1433. Unfortunately, I have no means to verify the last claim.