-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Tiny 2040 support for Pi 2040 mode. #1341
base: master
Are you sure you want to change the base?
Conversation
Thanks @theLMGN! |
@carlosperate I was using CircuitPython, however this works with MicroPython too. Not sure where the VID & PID come from, I just checked whatr it was identifying as on my local machine. DeviceHunt says it's from 'MCS' https://devicehunt.com/search/type/usb/vendor/16D0/device/08C7 so probably the latter. |
Right, so the odd thing is that the "normal" MicroPython build should configure the USB VID/PID to the values configured in the mode (0x2E8A/0x0005), and CircuitPython should be using the Adafruit VID 0x239A. If so, from where did you get the MicroPython/CircuitPython builds? |
This is what the Tiny 2040 shows up as when running CircuitPython
Also, serial confirms this.
|
Thanks for USB information! Looks like Pimoroni are using the
@theLMGN I assume the board still shows with VID If you like to update the PR to add these values for the CircuitPython mode we can definitely merge that. |
Yes. There is no special MP build for the Tiny 2040, you use regular Pi Pico buiilds
|
mu/modes/circuitpython.py
Outdated
@@ -72,6 +72,7 @@ class CircuitPythonMode(MicroPythonMode): | |||
(0x239A, 0x80AC, None, "Unexpected Maker FeatherS2"), | |||
(0x303A, 0x8002, None, "Unexpected Maker TinyS2"), | |||
(0x054C, 0x0BC2, None, "Spresense"), | |||
(0x16d0, 0x08c7, None, "Tiny 2040") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the tests are failing because the black formatter wants a comma here.
You can run the test locally with make check
(although if you are using Python 3.5 black won't run as it is not available)
Thanks for updating the PR @theLMGN! Added a couple of minor comments. |
@theLMGN we'll be merging CircuitPython PRs soon, as you happy to update this PR? Thanks again for your contribution! |
Thanks for the update @theLMGN! |
No description provided.