Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(error message): Clarify magic number mismatch error message between heap child information #118

Open
wants to merge 1 commit into
base: msys2-3_3_6-release
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions winsup/cygwin/dcrt0.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1360,12 +1360,25 @@ multiple_cygwin_problem (const char *what, uintptr_t magic_version, uintptr_t ve
system_printf ("%s magic number mismatch detected - %p/%ly", what, magic_version, version);
else
api_fatal ("%s mismatch detected - %ly/%ly.\n\
This problem is probably due to using incompatible versions of the cygwin DLL.\n\
This problem is probably due to using incompatible versions of the msys2 or cygwin DLL.\n\
msys2 uses pinned memory to share child information. All versions running must be the same magic_version.\n\
\n\
The magic versions are seen above as magic_version/version.\n\
\n\
Cygwin recommends the following fix:\n\
If cygwin1.dll is installed then make sure there is only one version installed.\n\
Quenty marked this conversation as resolved.
Show resolved Hide resolved
Search for cygwin1.dll using the Windows Start->Find/Search facility\n\
and delete all but the most recent version. The most recent version *should*\n\
reside in x:\\cygwin\\bin, where 'x' is the drive on which you have\n\
installed the cygwin distribution. Rebooting is also suggested if you\n\
are unable to find another cygwin DLL.",
are unable to find another cygwin DLL.\n\
\n\
Since msys-2.0.dll may be installed in multiple stand-alone tools, make sure\n\
each tool is using a compatible version of msys-2.0.dll, otherwise a mismatch\n\
may occur. You can search for msys-2.0.dll across your system. See msys-2.0.dll\n\
source code for history and what magic number is included.\n\
\n\
See https://www.msys2.org/docs/faq/ for more information.",
what, magic_version, version);
}

Expand Down