Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use tini to avoid zombie processes #6

Closed
wants to merge 1 commit into from
Closed

Conversation

lazka
Copy link
Member

@lazka lazka commented Jun 26, 2024

See #5

@lazka
Copy link
Member Author

lazka commented Jun 28, 2024

It's not clear if this helps, so closing for now.

If anyone ends up here and thinks otherwise, please speak up!

@lazka lazka closed this Jun 28, 2024
@jeremyd2019
Copy link
Member

I tried to do a little investigation, but keep in mind I don't really deal with docker. What I saw is that in the current normal case, when using podman run, PID 1 is filled by the instance of bash running the msys2 script. It seems bash is reaping child processes. When using this PR, PID 1 is filled by tini, and PID 2 is the bash running the msys2 script.

However, if I attempt to reproduce what GHA does by doing
podman run -it --entrypoint /usr/bin/tail ghcr.io/msys2/msys2-docker-experimental -f /dev/null, PID 1 is still tail and I get zombie processes even with this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants