Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build experimental wow64 support in wine #4

Merged
merged 3 commits into from
Jun 25, 2024
Merged

Build experimental wow64 support in wine #4

merged 3 commits into from
Jun 25, 2024

Conversation

jeremyd2019
Copy link
Member

Fixes #3 (the easy way)

@jeremyd2019
Copy link
Member Author

I've also started playing with building 32-bit wine separately (like was necessary before the experimental wow64 support was added), could potentially do a PR to demonstrate that too. It involves enabling i386 arch in apt list and installing a bunch of i386 dev packages though, which I had to copy-paste from the wine debian sources rather than using build-dep to pull them in.

seems like building experimental wow64 support results in it not naming the executable wine64 anymore
@jeremyd2019 jeremyd2019 marked this pull request as ready for review June 19, 2024 19:13
For pull requests, the images are not published, so it might be nice to have access to them to test
@jeremyd2019
Copy link
Member Author

Example workflow snippet to load the docker images from the artifacts:

      - uses: actions/download-artifact@v4
        with:
          name: docker-images
          github-token: ${{ github.token }}
          repository: msys2/msys2-docker
          run-id: 9592572891
      - name: import images
        run: |
          zstd -dc experimental.tar.zst | docker load
          zstd -dc devcontainer.tar.zst | docker load

That might have been a separate PR, but I wanted to test this PR adding 32-bit support. With it, I can run mingw32 and clang32 zstd at least.

@lazka lazka merged commit ebad769 into msys2:main Jun 25, 2024
1 check passed
@jeremyd2019 jeremyd2019 deleted the wine-wow64-support branch June 25, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enable i386 support
2 participants