Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ca-certificates: just call update-ca-trust in the install script #3492

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lazka
Copy link
Member

@lazka lazka commented Jan 12, 2023

currently the install script is more or less a copy of update-ca-trust, so to simplify things just call update-ca-trust in the install script

currently the install script is more or less a copy of update-ca-trust,
so to simplify things just call update-ca-trust in the install script
@jeremyd2019
Copy link
Member

wonder why it was done that way to begin with... maybe something to do with when it's invoked as an install script?

@lazka
Copy link
Member Author

lazka commented Jan 13, 2023

It was changed in 9841d13

I don't know why though. Maybe @Alexpux remembers?

@Biswa96
Copy link
Member

Biswa96 commented Jan 13, 2023

It was changed in 9841d13

The rest of that commit suggests that something happen with /bin -> /usr/bin like changes.

@lazka
Copy link
Member Author

lazka commented Jan 13, 2023

The only reason I can think of is pacman installing to a different root, but it still shouldn't make a difference due to chroot, see https://bbs.archlinux.org/viewtopic.php?pid=913891#p913891

@jeremyd2019
Copy link
Member

OK, the 'different root' install for making the installer was what I was most concerned about, since I remember this install script breaking in the past and causing issues. Probably would cause more issues now than before, with more of the extraneous first run actions being removed from filesystem.

@lazka
Copy link
Member Author

lazka commented Jan 14, 2023

I've added an optional input flag to the https://github.com/msys2/msys2-installer/actions/workflows/build.yml workflow, so we can test creating the installer from staging. edit: that turned out to be buggy... so reverted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants