Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: support MSW 2.0 #32

Merged
merged 2 commits into from
Nov 7, 2023
Merged

feat!: support MSW 2.0 #32

merged 2 commits into from
Nov 7, 2023

Conversation

stijnvanhulle
Copy link
Contributor

@stijnvanhulle stijnvanhulle commented Oct 25, 2023

Just stuck on the following issue(when building the examples with tsc)

node_modules/@mswjs/interceptors/node_modules/@open-draft/deferred-promise/build/index.d.ts:16:5 - error TS18028: Private identifiers are only available when targeting ECMAScript 2015 and higher.

16     #private;
       ~~~~~~~~


Found 1 error in node_modules/@mswjs/interceptors/node_modules/@open-draft/deferred-promise/build/index.d.ts:16

error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation 

UPDATE: resolved ✅

@stijnvanhulle stijnvanhulle marked this pull request as draft October 25, 2023 13:50
examples/mocks/index.ts Outdated Show resolved Hide resolved
src/middleware.ts Outdated Show resolved Hide resolved
src/middleware.ts Outdated Show resolved Hide resolved
src/middleware.ts Outdated Show resolved Hide resolved
test/middleware.test.ts Outdated Show resolved Hide resolved
Copy link
Member

@kettanaito kettanaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a fantastic change, @stijnvanhulle! I left a few comments, let me know what you think about those. Excited to see HTTP middleware being updated!

@stijnvanhulle stijnvanhulle marked this pull request as ready for review October 31, 2023 10:47
@kettanaito
Copy link
Member

kettanaito commented Nov 4, 2023

⚠️ Important note to myself

Update @ossjs/release before merging this. Release version this library is using is old and won't support the ! to trigger breaking version bumps.

kettanaito added a commit that referenced this pull request Nov 4, 2023
Updates to the newest Release. 

- Prerequisite for #32
Copy link
Member

@kettanaito kettanaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the library! Fantastic job 🎉

@kettanaito kettanaito changed the title feat!: support for MSW 2.0 feat!: support MSW 2.0 Nov 7, 2023
@kettanaito kettanaito merged commit 91249f9 into mswjs:main Nov 7, 2023
@kettanaito
Copy link
Member

Released: v0.9.0 🎉

This has been released in v0.9.0!

Make sure to always update to the latest version (npm i @mswjs/http-middleware@latest) to get the newest features and bug fixes.


Predictable release automation by @ossjs/release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants