5390 correctly handle gs1 2d data matrix format

[jmbrunskill]

Fixes #5390

👩🏻‍💻 What does this PR do?

I tried to make minimal changes for this, but it should allow us to scan GS1 formatted barcodes and create assets from them.

💌 Any notes for the reviewer?

Maybe/probably should remove the parsing of human readable string? Figured I'd leave it there for now as it might come in handy, and I didn't want to have to re-create data for all my tests cases and aiming for minimal changes here :)

Thoughts on this?

🧪 Testing

• Using either Android (with camera), or Desktop (with 2d Barcode Scanner)
• Open the cold chain equipment section, and click the Scan button (this doesn't show on web)
• Scan one of the barcodes below
• You should be prompted to create a new asset
• If you accept, it should show a new asset with the serial number, asset type, and Warenty date populated
• The Installation date should default to today
• Scanning the same barcode again, should navigate you to the right asset (once it has been created)

NOTE, scanning these 2d Matrixes in github dark mode or with a black background doesn't work well...
NOTE: in general scanning 2d Matrixes seems much less reliable than QR Codes, need to have camera straight on for example

Scan a GS1 formatted Data Matrix here (Note: or create your own for testing)

PQS Asset Type: E003/002
Serial Number: S12345678
https://bwipjs-api.metafloor.com/?bcid=gs1datamatrix&text=(01)09506000134352(11)241007(21)S12345678(241)E003/002(3121)820000(3131)670000(3111)630000(90)001(91)241007-310101

PQS Asset Type: E004/055
Serial Number: S1
https://bwipjs-api.metafloor.com/?bcid=gs1datamatrix&text=(01)09506000134352(11)241007(21)S1(241)E004/055(3121)820000(3131)670000(3111)630000(90)001(91)241007-310101

PQS Asset Type: E004/055
Serial Number S2
https://bwipjs-api.metafloor.com/?bcid=gs1datamatrix&text=(01)09506000134352(11)241007(21)S1(241)E004/055(3121)820000(3131)670000(3111)630000(90)001(91)241007-310101

📃 Documentation

• Part of an epic: documentation will be completed for the feature as a whole
• No documentation required: no user facing changes or a bug fix which isn't a change in behaviour
• These areas should be updated or checked:
  1.
  2.

[github-actions]

Bundle size difference

Comparing this PR to main

Old size	New size	Diff
4.97 MB	4.97 MB	189 B (0.00%)

[lache-melvin]

Working great! Thanks James 🚀

Maybe/probably should remove the parsing of human readable string? Figured I'd leave it there for now as it might come in handy, and I didn't want to have to re-create data for all my tests cases and aiming for minimal changes here :)

I feel ok leaving it there, it's pretty isolated and comes in handy for testing if nothing else 😁

[lache-melvin]

HAHA kidding wait I built it I didn't test hold fire

[lache-melvin]

#exposed

[lache-melvin]

Alas:

[lache-melvin]

Ah - I think parseBarcode isn't returning anything? This is the ScanResult in handleScanResult:

[lache-melvin]

I think I see the issue, doing a quick test build now, will update you :)

[lache-melvin]

Ok there are two issues:

The parseResult being called in the electron scanning code, but not for android:

open-msupply/client/packages/common/src/utils/BarcodeScannerContext.tsx

Lines 173 to 190 in 1d76ccd

	if (hasNativeBarcodeScanner) {
	setIsScanning(true);
	const timeout = setTimeout(async () => {
	await stopScan();
	if (!hasElectronApi) error(t('error.unable-to-read-barcode'))();
	}, SCAN_TIMEOUT_IN_MS);
	// Check camera permission
	await BarcodeScannerPlugin.checkPermission({ force: true });
	// make background of WebView transparent
	BarcodeScannerPlugin.hideBackground();
	const result = await BarcodeScannerPlugin.startScan(); // start scanning and wait for a result
	clearTimeout(timeout);
	setIsScanning(false);
	BarcodeScannerPlugin.showBackground();
	callback(result);
	}

However, I added the parseResult call there, and still the gs1 result of parseBarcode is coming back empty... don't have time to investigate further tonight sorry, I think a tomorrow problem 😁

[jmbrunskill]

However, I added the parseResult call there, and still the gs1 result of parseBarcode is coming back empty... don't have time to investigate further tonight sorry, I think a tomorrow problem 😁

Dang, was hopeful! Thanks for testing!