Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4935 Change ledger number column to "invoice no." #5393

Merged
merged 2 commits into from
Nov 13, 2024
Merged

4935 Change ledger number column to "invoice no." #5393

merged 2 commits into from
Nov 13, 2024

Conversation

lache-melvin
Copy link
Contributor

Fixes #4935

👩🏻‍💻 What does this PR do?

Change number column to say Invoice no.:
Screenshot 2024-11-13 at 1 10 06 PM

💌 Any notes for the reviewer?

Wrapping looks a bit silly on other pages like outbound shipment - Should those continue to only say Number?

🧪 Testing

  • View Stock -> detail view -> ledger tab
  • number column now says Invoice no.

📃 Documentation

  • Part of an epic: documentation will be completed for the feature as a whole
  • No documentation required: no user facing changes or a bug fix which isn't a change in behaviour
  • These areas should be updated or checked:
    1.
    2.

@github-actions github-actions bot added this to the Refactor fortnight milestone Nov 13, 2024
@github-actions github-actions bot added bug Something is borken good first issue Good for newcomers front-end Front-end related Severity: Low Bugs that don't block workflows. UX like wrong fonts, bad layout... labels Nov 13, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 13, 2024 •
edited
Loading

Bundle size difference

Comparing this PR to main

Old size New size Diff
4.97 MB 4.97 MB 16 B (0.00%)

roxy-dao
roxy-dao reviewed Nov 13, 2024
View reviewed changes
client/packages/common/src/intl/locales/en/common.json Outdated
@@ -738,7 +738,7 @@
"label.initialise-store-properties": "Initialise store properties for GAPS",
"label.initialised": "Initialised",
"label.installation-date": "Installation date",
"label.invoice-number": "Number",
"label.invoice-number": "Invoice No.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this say number D: please and ty <3

@roxy-dao roxy-dao self-assigned this Nov 13, 2024
@lache-melvin lache-melvin changed the base branch from develop to v2.4.1 November 13, 2024 04:48
@github-actions github-actions bot modified the milestones: v2.4.1, Refactor fortnight Nov 13, 2024
@lache-melvin lache-melvin changed the base branch from v2.4.1 to v2.4.0 November 13, 2024 04:48
@lache-melvin
Copy link
Contributor Author

Moved to 2.4... I think small enough?

roxy-dao
roxy-dao approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@roxy-dao roxy-dao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup! I think small enough to be in 2.4 (:

LGTM!

@lache-melvin lache-melvin merged commit 6234f6f into v2.4.0 Nov 13, 2024
4 checks passed
@lache-melvin lache-melvin deleted the 4935-item-ledger-number-column branch November 13, 2024 20:02
@roxy-dao roxy-dao mentioned this pull request Nov 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roxy-dao roxy-dao roxy-dao approved these changes

Assignees

@roxy-dao roxy-dao

Labels
bug Something is borken front-end Front-end related good first issue Good for newcomers Severity: Low Bugs that don't block workflows. UX like wrong fonts, bad layout...
Projects
None yet
Milestone
v2.4.0-RC2
Development

Successfully merging this pull request may close these issues.

Item ledger - Column named 'Number' confuses users
2 participants
@lache-melvin @roxy-dao