-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
203 notification events view #223
Conversation
Bundle size differenceComparing this PR to
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
π Lots of great stuff there! So good to have a list of events easily viewable.
Couple of general comments: I would use a modal for the detail view, rather than a new page - there's nothing in the nav when you are on the detail page. The Events
menu isn't highlight and it's like you are in some strange limbo..
Is the edit list only for events? so the edit button always applies?
The filters - I find it strange having them spaced across the width of the page. I'd jam them all together, or using the omSupply FilterBar component.
frontend/packages/system/src/NotificationEvents/DetailView/DetailView.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/system/src/NotificationEvents/DetailView/DetailView.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/system/src/NotificationEvents/DetailView/DetailView.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/system/src/NotificationEvents/DetailView/DetailView.tsx
Outdated
Show resolved
Hide resolved
EventStatus, | ||
} from '@notify-frontend/common'; | ||
|
||
export const FilterBar = ({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this would benefit from taking the new FilterBar from omSupply and implementing the filters from there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mark-prins Do you have a link to the New FilterBar
? There doesn't seem to be a common component called that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the work has been done on the release candidate branch - sorry, was going to chat to you about this one!
There's various PRs demonstrating the usage - you could try the location filter one as start maybe?
frontend/packages/system/src/NotificationEvents/ListView/FilterBar.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/system/src/NotificationEvents/ListView/ListView.tsx
Outdated
Show resolved
Hide resolved
A lot of the app navigates to a new page for a detail view. Maybe we just need to fix the highlighting? |
Closes #203
π©π»βπ» What does this PR do?
Adds a Event Log View to allow administrators to see what messages were sent and any errors...
Filter By Status:
Filter By Time Range:
Search:
Navigate to detailed view, and on to notification configuration:
Detailed View (SENT):
Detailed View (FAILED):
π§ͺ How has/should this change been tested?
Did some local testing.
π Any notes for the reviewer?