Add Lenovo Yoga Tab 3 10 LTE support #434
Conversation
exkc
commented
Oct 17, 2024
exkc
commented
|
|
||
| &lk2nd { | ||
| lxf_p5001_b01 { | ||
| model = "Lenovo Yoga Tab 3 10 LTE"; |
There was a problem hiding this comment.
i proby should name it as lxf_p5001.
apparently there are other Lenovo Yoga Tab 3 10 (wifi/lte) are called lxf_p5001 but different sufixes like b01,j01,etc
| }; | ||
|
|
||
| &lk2nd { | ||
| lxf_p5001_b01 { |
There was a problem hiding this comment.
I'd prefer to conform to linux code style for dts in which underscores are not used in names, you can drop the b01 suffix if you think that's more correct
| lxf_p5001_b01 { | |
| lxf-p5001-b01 { |
exkc
force-pushed
the
yt3-x50y
branch
2 times, most recently
from
16f1ca8
to
2044140
Compare
| }; | ||
|
|
||
| &lk2nd { | ||
| // The motherboard of it has QR code sticker has a code name printed on it.All Lenovo Yoga Tab 3 10 LTE/WiFi varian code name appear to have lxf-p5100 prefix and a lot of different suffix. this device is particular known for having b1 suffix and yt3-x50y model number. |
There was a problem hiding this comment.
I'd appreciate if this comment were to be C style (/**/) and folded at 60-80. This would make it easier to read
There was a problem hiding this comment.
i removed it bc there are a issue : I don't know how do we gonna match different model/varian.
There was a problem hiding this comment.
I mean what if a different model/varian's bootloader select the same tree then how we going to differentiate them. Also Lenovo probably used same panel on Lenovo Yoga Tab 3 10.
the only thing I know so far at least we can differentiate the Wi-Fi vaint and LTE vaint . those vaint proby not goona selecting the same tree
|
Thanks! |
