Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Samsung Grand Prime (SM-G530M) STABLE 🗡️ #308

Closed
wants to merge 42 commits into from

Conversation

pachof
Copy link

@pachof pachof commented Oct 3, 2023

This uses the dts of Samsung Galaxy Prime GT 530Y and W

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just need some minor changes.

dts/msm8916/msm8916-samsung-r11.dts Outdated Show resolved Hide resolved
@@ -1,5 +1,5 @@
name: lk2nd
on: [push, pull_request]
on: [workflow_dispatch, push, pull_request]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would you need to modify this file?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to remove those non-relevant files but I don't know how, I modified that because I needed it to compile

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

git checkout origin/master .github/workflows/lk2nd.yml and commit.

For online helps with instant messages, #msm8916:postmarketos.org

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I already removed the file I didn't want thanks

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well I don't think it's necessary to touch it, including removing it.

@pachof pachof changed the title Add Samsung Grand Prime (SM-G530M) STABLE Add Samsung Grand Prime (SM-G530M) STABLE 🗡️ Oct 25, 2023
@pachof
Copy link
Author

pachof commented Oct 25, 2023

yeaaa

type: string
vars:
type: string
name: Building
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do these changes have anything to do with Add Samsung Grand Prime (SM-G530M)?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I wanted to modify my repository so that the artifacts can be downloaded, I didn't know that it would be reflected, how do I prevent these changes from occurring?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For online helps, please feel free to come back to #msm8916:postmarketos.org .

Maybe you can push it to another branch, with git switch -c <new_branch> and git push <your_repo> [new_branch]. Uppercase -C to overwrite, if necessary.

For this PR, you can also try to create another branch fortunalteub with:

  1. git checkout origin/master to checkout to origin/master
  2. git switch -c fortunalteub to switch and create branch fortunalteub
  3. git cherry-pick ddea3ace6cf69768627ea19506398254d52ab9d6 b6f59726c60a9bca5365d26ac1b309d0b39b1d28 to cherry-pick 2 relevant commits
  4. git rebase -i origin/master to rebase
  5. In the editor:
pick ddea3ace6cf69768627ea19506398254d52ab9d6  ...
# fixup with previous commit
fixup b6f59726c60a9bca5365d26ac1b309d0b39b1d28 ...
# execute git commit --amend -m <commit_message>
exec git commit --amend -m "dts: Add Samsung Galaxy Grand Prime (SM-G530Y)"
  1. git push <your_repo>, and open another clean PR.
    • or git push <your_repo> fortunalteub:master to replace your current branch master in this PR

@TravMurav TravMurav deleted the branch msm8916-mainline:master May 27, 2024 13:33
@TravMurav TravMurav closed this May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants