-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Samsung Grand Prime (SM-G530M) STABLE 🗡️ #308
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, just need some minor changes.
.github/workflows/lk2nd.yml
Outdated
@@ -1,5 +1,5 @@ | |||
name: lk2nd | |||
on: [push, pull_request] | |||
on: [workflow_dispatch, push, pull_request] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why would you need to modify this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to remove those non-relevant files but I don't know how, I modified that because I needed it to compile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
git checkout origin/master .github/workflows/lk2nd.yml
and commit.
For online helps with instant messages, #msm8916:postmarketos.org
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I already removed the file I didn't want thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well I don't think it's necessary to touch it, including removing it.
Co-authored-by: Raymond Hackley <[email protected]>
yeaaa |
type: string | ||
vars: | ||
type: string | ||
name: Building |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do these changes have anything to do with Add Samsung Grand Prime (SM-G530M)
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, I wanted to modify my repository so that the artifacts can be downloaded, I didn't know that it would be reflected, how do I prevent these changes from occurring?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For online helps, please feel free to come back to #msm8916:postmarketos.org .
Maybe you can push it to another branch, with git switch -c <new_branch>
and git push <your_repo> [new_branch]
. Uppercase -C
to overwrite, if necessary.
For this PR, you can also try to create another branch fortunalteub
with:
git checkout origin/master
to checkout toorigin/master
git switch -c fortunalteub
to switch and create branchfortunalteub
git cherry-pick ddea3ace6cf69768627ea19506398254d52ab9d6 b6f59726c60a9bca5365d26ac1b309d0b39b1d28
to cherry-pick 2 relevant commitsgit rebase -i origin/master
to rebase- In the editor:
pick ddea3ace6cf69768627ea19506398254d52ab9d6 ...
# fixup with previous commit
fixup b6f59726c60a9bca5365d26ac1b309d0b39b1d28 ...
# execute git commit --amend -m <commit_message>
exec git commit --amend -m "dts: Add Samsung Galaxy Grand Prime (SM-G530Y)"
git push <your_repo>
, and open another clean PR.- or
git push <your_repo> fortunalteub:master
to replace your current branchmaster
in this PR
- or
This uses the dts of Samsung Galaxy Prime GT 530Y and W