dts: msm8974: hammerhead: fix msm-id overrides #284
Conversation
|
Can you explain what exactly you are fixing here? What is the problem with the current definitions? How do your changes help? Please extend the commit message. :) |
|
I am not sure how to describe the commit. The point is to improve the readability and reduce quirks. |
| @@ -7,9 +7,12 @@ | |||
|
|
|||
| / { | |||
| // This is used by the bootloader to find the correct DTB | |||
| qcom,msm-id = <0x7e 0x96 0x20002 0x2b>; | |||
| qcom,msm-id = <126 150 0x20002>; | |||
There was a problem hiding this comment.
This is the part I'm mainly confused about. If I remember correctly the original bootloader on hammerhead wants to have this msm-id with 4 elements since the 0x2b at the end encodes the board revision. Are you saying that it's not actually necessary to boot lk2nd?
There was a problem hiding this comment.
"To boot lk2nd from original bootloader", no.
The original bootloader also boots qcom,msm-id = <126 150 0x20002>;/qcom,msm-id = <0x7e 0x96 0x20002>;.
However, "to boot lk2nd from lk2nd", it's currently not possible yet, since it gets confused with the dtbs.
#285
"To boot downstream boot/recovery image from lk2nd", aa6713e is still required. And proper msm-id/board-id are also required to find proper dtbs.
No description provided.