-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/metafusion script error exiting behavior #119
Conversation
I could have added a test here for metafusion only, but I think a better option will be to add a test for the fusion merging and annotation workflow in another PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont know explicitly how test works (L75 and L126 in metafusion_forte.sh).
Asssuming the line is just a trycatch like condition it should be fine so long as we are still outputting the files the grep conditions are running
@pintoa1-mskcc So the reason i added this is because grep will have a non-zero exit code if 0 matches are found in the input file. The changes are a way to bypass any exit code of 1 ( |
Closes #116
PR checklist
nf-core lint
).nextflow run . -profile test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).