Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/metafusion script error exiting behavior #119

Merged
merged 5 commits into from
Aug 6, 2024

Conversation

anoronh4
Copy link
Collaborator

@anoronh4 anoronh4 commented Aug 1, 2024

Closes #116

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the mskcc/forte branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@anoronh4 anoronh4 changed the title Bugfix/metafusion tmpdir Bugfix/metafusion script error exiting behavior Aug 6, 2024
@anoronh4
Copy link
Collaborator Author

anoronh4 commented Aug 6, 2024

I could have added a test here for metafusion only, but I think a better option will be to add a test for the fusion merging and annotation workflow in another PR.

@anoronh4 anoronh4 marked this pull request as ready for review August 6, 2024 19:36
@anoronh4 anoronh4 linked an issue Aug 6, 2024 that may be closed by this pull request
Copy link
Collaborator

@pintoa1-mskcc pintoa1-mskcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont know explicitly how test works (L75 and L126 in metafusion_forte.sh).

Asssuming the line is just a trycatch like condition it should be fine so long as we are still outputting the files the grep conditions are running

@anoronh4
Copy link
Collaborator Author

anoronh4 commented Aug 6, 2024

I dont know explicitly how test works (L75 and L126 in metafusion_forte.sh).

Asssuming the line is just a trycatch like condition it should be fine so long as we are still outputting the files the grep conditions are running

@pintoa1-mskcc So the reason i added this is because grep will have a non-zero exit code if 0 matches are found in the input file. The changes are a way to bypass any exit code of 1 ($? = 1). i think this can happen, for example, if the input cff doesn't have any "problematic" chromosomes, or if there are no ReadThrough calls. I'm not sure what other errors we could be ignoring that would be a problem.

@anoronh4 anoronh4 merged commit bf5e80d into develop Aug 6, 2024
6 checks passed
@anoronh4 anoronh4 linked an issue Aug 21, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

metafusion not exiting when error occurs offline usage
2 participants