Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bolt v2 #24

Merged
merged 15 commits into from
Sep 18, 2018
Merged

Bolt v2 #24

merged 15 commits into from
Sep 18, 2018

Conversation

dominique-vassard
Copy link
Contributor

Evolutions discussed in #22 :

  • Message encoding / decoding as first encoding /decoding stage
  • Message logging

And other quick fixes

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.2%) to 95.139% when pulling 48118c4 on dominique-vassard:bolt_v2 into b12f3e7 on mschae:master.

@dominique-vassard
Copy link
Contributor Author

@mschae Any news about his PR?
I saw that the coverage decrease but it's due to the logger.ex, especially the hex logging system, which is not tested because it caused performance drop. I don't think it's a problem as it is not a critical part.

@mschae mschae merged commit 634b324 into mschae:master Sep 18, 2018
@mschae
Copy link
Owner

mschae commented Sep 18, 2018

@dominique-vassard Just slipped by - I apologize. Merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dominique-vassard @coveralls @mschae