Draft assertLargeDatasetEqualityV2 #181
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alfonsorr @SemyonSinchenko Benchmark result is promising. runtime of dataframe only API is 10x faster than RDD usage |
zeotuan
force-pushed
the
nonRddAssert
branch
from
e6caa63 to
a528229
Compare
zeotuan
commented
Jan 4, 2025
| * @param checkKeyUniqueness | ||
| * if true, will check if the primary key is actually unique | ||
| */ | ||
| def assertLargeDatasetEqualityV2[T: ClassTag]( |
There was a problem hiding this comment.
How should we approach this? Should I add more version that is closer to what we had before? or maybe just use this replace older version with this
There was a problem hiding this comment.
TODO: add performance benchmark for Typed vs column filter
In theory Filter using column should allow better query plan generation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.