Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse systems that periodically zero #16

Merged
merged 11 commits into from
Aug 9, 2024
Merged

Parse systems that periodically zero #16

merged 11 commits into from
Aug 9, 2024

Conversation

richfitz
Copy link
Member

@richfitz richfitz commented Aug 6, 2024

I had larger ambitions with this (see the commit log if curious - this has spawned some tickets for later). In the end this is pretty simple

@richfitz richfitz marked this pull request as ready for review August 8, 2024 15:12
Copy link
Contributor

@weshinsley weshinsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - just a missing error (1099?) to be added to the vignette (and sysdata.rda)

R/parse_expr.R Outdated
if (!(identical(rhs$expr, 0) || identical(rhs$expr, 0L))) {
odin_parse_error(
"Initial condition of periodically zeroed variable must be 0",
"E1099", src, call)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have an uncommitted update for errors.Rmd for E1099? (OR perhaps 1099 is a placeholder - next entry would be E1019)

Copy link
Contributor

@weshinsley weshinsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorted

@weshinsley weshinsley merged commit 3b91997 into main Aug 9, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants