-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse systems that periodically zero #16
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - just a missing error (1099?) to be added to the vignette (and sysdata.rda)
R/parse_expr.R
Outdated
if (!(identical(rhs$expr, 0) || identical(rhs$expr, 0L))) { | ||
odin_parse_error( | ||
"Initial condition of periodically zeroed variable must be 0", | ||
"E1099", src, call) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have an uncommitted update for errors.Rmd for E1099? (OR perhaps 1099 is a placeholder - next entry would be E1019)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorted
I had larger ambitions with this (see the commit log if curious - this has spawned some tickets for later). In the end this is pretty simple