Generate adjoint model for simple discrete-time systems #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weshinsley
approved these changes
Aug 7, 2024
| @@ -10,12 +10,23 @@ generate_dust_sexp <- function(expr, dat, options = list()) { | |||
| ret <- sprintf("-%s", args[[1]]) | |||
| } else if (n == 1 && fn == "+") { | |||
| ret <- args[[1]] | |||
| } else if (n == 2 && fn %in% c("+", "-", "*", "/")) { | |||
| } else if (n == 2 && fn %in% c("+", "-", "*", "/", "==")) { | |||
There was a problem hiding this comment.
Just to check, are we happy here with == re the usual floating point comparison story?
There was a problem hiding this comment.
yeah, this is subject to the usual issues, but we don't try and be clever here (this has been in odin1 forever and works quite well in practice)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on
Probably best to review and merge after #12 because that'll make getting an integration test in much easierIt is currently based off of #9 so that the scale of the PR is clearer -it's not that long, but it's all killer no filler.The testing is not amazing, but it's a start. The integration test here is doing a lot of heavy lifting, combined with keeping track of the generated code.