Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Wes Hinsley <[email protected]>
  • Loading branch information
richfitz and weshinsley authored Nov 14, 2024
1 parent 0fb98d5 commit 482240a
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions tests/testthat/test-parse.R
Original file line number Diff line number Diff line change
Expand Up @@ -1029,7 +1029,7 @@ test_that("RHS array for non-dimensioned variable", {
update(x) <- a[1]
update(a) <- 1
}),
"Missing 'dim\\(\\)' for expression used as an array")
"Missing 'dim()' for expression used as an array", fixed = TRUE)
})

test_that("Invalid argument to func that expects an array", {
Expand Down Expand Up @@ -1069,7 +1069,7 @@ test_that("Non-array passed to func that expects an array", {
initial(y) <- 0
update(y) <- 1
}),
"Missing 'dim\\(\\)' for expression used as an array"
"Missing 'dim()' for expression used as an array", fixed = TRUE
)
})

Expand Down
2 changes: 1 addition & 1 deletion vignettes/errors.Rmd
Original file line number Diff line number Diff line change
Expand Up @@ -1119,7 +1119,7 @@ b <- a + 1
browser("update")
```

Because the `browser` call is always put a the end of the phase, repeating `browser()` as above does not achieve anything.
Because the `browser` call is always put at the end of the phase, repeating `browser()` as above does not achieve anything.

# `E3001`

Expand Down

0 comments on commit 482240a

Please sign in to comment.