Improve warnings #453
Open
Improve warnings #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-ash
requested changes
Nov 19, 2024
| @@ -329,6 +329,12 @@ naomi_model_frame <- function(area_merged, | |||
| ## of a Spectrum file and then calibrated. Currently no way to know if areas | |||
| ## comparise only part of a Spectrum file, so can't address. | |||
|
|
|||
| if(any( mf_areas[["area_id"]] %in% unique(population_agesex$area_id) == FALSE)){ | |||
There was a problem hiding this comment.
Suggested change
| if(any( mf_areas[["area_id"]] %in% unique(population_agesex$area_id) == FALSE)){ | |
| if (!all(mf_areas[["area_id"]] %in% unique(population_agesex$area_id))) { |
| @@ -329,6 +329,12 @@ naomi_model_frame <- function(area_merged, | |||
| ## of a Spectrum file and then calibrated. Currently no way to know if areas | |||
| ## comparise only part of a Spectrum file, so can't address. | |||
|
|
|||
| if(any( mf_areas[["area_id"]] %in% unique(population_agesex$area_id) == FALSE)){ | |||
| stop( | |||
There was a problem hiding this comment.
Can you add a translation for this error?
| @@ -1,3 +1,7 @@ | |||
| # naomi 2.10.2 | |||
|
|
|||
| * Improve warning generated when user fits model at admin level where no population data exists. | |||
There was a problem hiding this comment.
Suggested change
| * Improve warning generated when user fits model at admin level where no population data exists. | |
| * Improve error generated when user fits model at admin level where no population data exists. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate more informative warning when user select area level to generate model estimates for which population data is not available