Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since updating spdep to v 1.3.6 we're seeing more warnings being raised for Naomi test data:
Warning messages:
1: In spdep::poly2nb(sh) : some observations have no neighbours;
if this seems unexpected, try increasing the snap argument.
2: In spdep::poly2nb(sh) : neighbour object has 2 sub-graphs;
if this sub-graph count seems unexpected, try increasing the snap argument.
3: In spdep::mat2listw(abs(Q), style = "B", zero.policy = TRUE) :
neighbour object has 2 sub-graphs
Stack trace
This is expected as Likoma island is separate, and it will potentially be super noisy for running tests and the production app. So suppress the warnings for now.
I have done this by updating our
suppress_one_*
utils into a singlesuppress_conditions
where you can specify the messages and warnings you want to ignore.