-
-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a z-index input property on ng-http-loader component #189
base: master
Are you sure you want to change the base?
Conversation
Pull Request Test Coverage Report for Build 7196877749
💛 - Coveralls |
Thanks for this PR. |
This is the actual solution that I had inside my app. However, if the CSS selector changes overtime, the added CSS will fail. Also, maybe I am missing a cleaner way of doing it, but having to add I don't know what the good practice is here |
Sure, that's why i'm wondering if we should not think about a more universal solution, like giving the ability to specify a custom CSS class, so people consuming this lib are safer, and have much more css possibilities.With a css class, the selector is directly handled by the dev, and overrides are much simpler |
A much better solution! I'll make these changes asap |
Take your time to battle test it. And please, let's discuss in another PR. |
Add a way to specify a z-index for the component. Default stays 9999.
PS: thanks for this nice package.