staticanalysis/bot: Use Taskcluster cache for sharebase only, refs #1923

 (#1942)

src/staticanalysis/bot/default.nix

@@ -49,6 +49,7 @@ let
 
   mkBot = branch:
     let
+      cacheKey = "services-" + branch + "-static-analysis-bot";
       secretsKey = "repo:github.com/mozilla-releng/services:branch:" + branch;
       hook = mkTaskclusterHook {
         name = "Static analysis automated tests";
@@ -75,12 +76,18 @@ let
           # Send emails to relman
           "notify:email:*"
 
+          # Used by cache
+          ("docker-worker:cache:" + cacheKey)
+
           # Needed to index the task in the TaskCluster index
           ("index:insert-task:project.releng.services.project." + branch + ".static_analysis_bot.*")
 
           # Needed to download the Android sdks for Infer
           "queue:get-artifact:project/gecko/android-*"
         ];
+        cache = {
+          "${cacheKey}" = "/cache";
+        };
         taskEnv = fullTaskEnv {
           "SSL_CERT_FILE" = "${cacert}/etc/ssl/certs/ca-bundle.crt";
           "APP_CHANNEL" = branch;

src/staticanalysis/bot/static_analysis_bot/config.py

@@ -23,6 +23,7 @@
 REPO_TRY = b'https://hg.mozilla.org/try'
 SOURCE_PHABRICATOR = 'phabricator'
 SOURCE_TRY = 'try'
+TASKCLUSTER_CACHE = '/cache'
 
 logger = get_logger(__name__)
 
@@ -96,10 +97,10 @@ def setup(self,
         except KeyError:
             raise Exception('Publication mode should be {}'.format('|'.join(map(lambda p: p .name, Publication))))
 
+        # Repository is always on local instance
         if not os.path.isdir(work_dir):
             os.makedirs(work_dir)
         self.repo_dir = os.path.join(work_dir, 'sa-unified')
-        self.repo_shared_dir = os.path.join(work_dir, 'sa-unified-shared')
 
         # Save Taskcluster ID for logging
         if 'TASK_ID' in os.environ and 'RUN_ID' in os.environ:
@@ -109,6 +110,14 @@ def setup(self,
         if not os.path.isdir(self.taskcluster.results_dir):
             os.makedirs(self.taskcluster.results_dir)
 
+        # Repository sharebase (for robustcheckout) is either
+        # * on the available Taskcluster cache, when running online
+        # * on the local instance, for developers
+        if not self.taskcluster.local and os.path.isdir(TASKCLUSTER_CACHE):
+            self.repo_shared_dir = os.path.join(TASKCLUSTER_CACHE, 'sa-unified-shared')
+        else:
+            self.repo_shared_dir = os.path.join(work_dir, 'sa-unified-shared')
+
         # Save allowed paths
         assert isinstance(allowed_paths, list)
         assert all(map(lambda p: isinstance(p, str), allowed_paths))

src/staticanalysis/bot/static_analysis_bot/workflows/local.py

@@ -61,8 +61,7 @@ def clone(self, revision):
         '''
         Clone mozilla-unified
         '''
-        logger.info('Clone mozilla unified', dir=settings.repo_dir)
-
+        logger.info('Clone mozilla unified', dir=settings.repo_dir, shared=settings.repo_shared_dir)
         if settings.source == SOURCE_TRY:
             # Clone Try using the target revision
             assert revision.mercurial_revision is not None, 'Missing try mercurial revision'
@@ -108,7 +107,7 @@ def _log_process(output, name):
         while proc.poll() is None:
             _log_process(proc.stdout, 'clone')
             _log_process(proc.stderr, 'clone (err)')
-            time.sleep(1)
+            time.sleep(2)
 
         out, err = proc.communicate()
         if proc.returncode != 0: