Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement whitelist in ExportConfig #978

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AnthonyYoManz
Copy link

@AnthonyYoManz AnthonyYoManz commented Jun 24, 2024

Adds a field whitelist to ExportConfig, allowing users to specify an exclusive list of items they wish to include in the generated header file. If the field is left empty it is ignored.

If excludes or includes are specified, they override the whitelist. For example in the case where we have functions foo, bar, and baz and our whitelist specifies foo and bar, then only foo and bar will be included in the output header file. If they add an include baz, all three functions will be included in the output. If they then add an exclude foo, only bar and baz will be included in the output.

Closes #484

@AnthonyYoManz
Copy link
Author

AnthonyYoManz commented Jun 24, 2024

Maybe I've missed it but I could not find where tests for other ExportConfig fields are, so I took the path of least resistance and simply wrote none for this - although I did test 'manually' by writing a separate crate and making sure behaviour was as described in my PR description. With some guidance on where exactly to put such a test I am happy to write it myself, although it might be a little awkward as I am on Windows and the entire test-suite very much does not function on this platform.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add whitelist to [export]
1 participant