Updated general exceptions with specific ones.

[prernadabi23]

Added ValueError replacing Exception Error.

Signed-off-by: Prerna Dabi [email protected]

fixes #3337

[suhaibmujahid]

Thank you, @prernadabi23

This PR fixes:
#3337

The goal of #3337 is to replace all cases not only in model.py. I will merge this PR for now, but it will not close the issue.

[suhaibmujahid]

@prernadabi23 could you please edit the pull request title to something more descriptive?

[prernadabi23]

Thank you, I will update it in all files.

[suhaibmujahid]

Thank you, I will update it in all files.

Thank you! Then, could you please link your pull request to the issue?

[prernadabi23]

Thank you, I will update it in all files.

Thank you! Then, could you please link your pull request to the issue?

I am not able to understand as I have already linked it.

[suhaibmujahid]

Thank you! Then, could you please link your pull request to the issue?

I am not able to understand as I have already linked it.

To allow GitHub to link the pull request to an issue, the keyword (i.e., "fixes") and the issue number should be in the same line without any special characters in between (e.g., fixes #3337).

See more here: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue

[prernadabi23]

@suhaibmujahid I mistakenly changed the PR name, and that has led to failing the lint check...
can you please look into this issue?

[suhaibmujahid]

@suhaibmujahid I mistakenly changed the PR name, and that has led to failing the lint check... can you please look into this issue?

The lint error is not related to the PR name/title. The patch has a formatting problem, see: https://community-tc.services.mozilla.com/tasks/Ap5h1JETTveSymWIgrqscg/runs/0/logs/public/logs/live.log#L168-184

To avoid lint failures, it is recommended to setup pre-commit: https://github.com/mozilla/bugbug#auto-formatting

Since your changes have already been committed, once you have pre-commit installed, you can test all files using the following command:

pre-commit run --all-files

[prernadabi23]

@suhaibmujahid I did "pre-commit run --all-files". What else needs to be done? The error is still there.

[suhaibmujahid]

@suhaibmujahid I did "pre-commit run --all-files". What else needs to be done? The error is still there.

You need to fix the lint errors and commit the fix.

[prernadabi23]

@suhaibmujahid I am getting a flake8 error. Else everything is passed.

$ pre-commit run --all-files
isort....................................................................Passed
black....................................................................Passed
prettier.................................................................Passed
flake8...................................................................Failed

• hook id: flake8
• exit code: 1

//////////////////////////////////////////////////////////////////////////////////////////

check python ast.........................................................Passed
check docstring is first.................................................Passed
check that executables have shebangs.....................................Passed
check for merge conflicts................................................Passed
check for broken symlinks............................(no files to check)Skipped
debug statements (python)................................................Passed
trim trailing whitespace.................................................Passed
check yaml...............................................................Passed
mixed line ending........................................................Passed
python tests naming......................................................Passed
check json...............................................................Passed
fix requirements.txt.....................................................Passed
check vcs permalinks.....................................................Passed
codespell................................................................Passed
taskcluster_yml..........................................................Passed
Strip unnecessary # noqas..............................................Passed
mypy-bugbug..............................................................Passed
mypy-bugbug-http.........................................................Passed
Check for useless excludes...............................................Passed

[prernadabi23]

@suhaibmujahid It's all done.

[prernadabi23]

@suhaibmujahid you can check now.

[prernadabi23]

@suhaibmujahid Can you confirm these changes, then I'll make the changes there.

[suhaibmujahid]

@suhaibmujahid Can you confirm these changes, then I'll make the changes there.

You could commit the changes without asking 🙂

[prernadabi23]

@suhaibmujahid I don't know why the lint error is there, all checks are passing as you can see.

[prernadabi23]

I am running two repos simultaneously, I'll fix this.

[prernadabi23]

@suhaibmujahid Can you please look into this? I am trying but still no change.

[suhaibmujahid]

LGTM. Thank you, @prernadabi23!

[marco-c]

Thanks!

[prernadabi23]

@suhaibmujahid @marco-c Thank you so much ..! and @suhaibmujahid thank you for helping me in every step, learned a lot during this process.