Bump Rust to 1.84.0 to match mozilla-central #6572
Merged
+36
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhammond
commented
Jan 29, 2025
| @@ -24,3 +24,6 @@ uniffi = { version = "0.28.2", features=["build"]} | |||
| # Temp hack for uniffi 0.28 generated code, will not be necessary after next uniffi update. | |||
| [lints.clippy] | |||
| empty-line-after-doc-comments = "allow" | |||
|
|
|||
| [features] | |||
There was a problem hiding this comment.
this one surprised me - the error crate had a cfg gate for a non-defined feature. Due to the use of macros, this feature also bleeds into rc_crypto. I think we can probably kill this feature as it's (obviously) unused, but I didn't want to do that here at this time (although open to suggestions I should)
mhammond
commented
Jan 29, 2025
| @@ -2,6 +2,8 @@ | |||
| * License, v. 2.0. If a copy of the MPL was not distributed with this | |||
| * file, You can obtain one at https://mozilla.org/MPL/2.0/. */ | |||
|
|
|||
| #![allow(unexpected_cfgs)] | |||
There was a problem hiding this comment.
This one is because clippy is complaining about some feature when using [ctor::ctor]. I'm not sure how that feature relates, but this is test code so I took the path of least resistance.
mhammond
force-pushed
the
push-zovppususwll
branch
4 times, most recently
from
d4bcb6c to
67269e2
Compare
mhammond
force-pushed
the
push-zovppususwll
branch
from
67269e2 to
c7d4d76
Compare
|
Now with bonus openssl version bump! |
bendk
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
[ci full]to the PR title.Branch builds: add
[firefox-android: branch-name]to the PR title.