-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update gradle files to work in both app-services and mozilla-central #6550
base: main
Are you sure you want to change the base?
Conversation
535d001
to
24044d0
Compare
Nothing here looks particularly likely to cause pain in the future. I'm generally concerned that we don't have a lot of high-level oversight of the Gradle build system, and that's causing slow builds and awkward development experiences (that look to get worse before they get much better), but that's the world we're in right now and nothing here is likely to make that more than linearly worse. |
Awesome, thanks Nick! I guess I might as well open this for review then! |
…of rootDir. The intent is that this will be the same as `rootDir` when in app-services, but magically turn into the root of the app-services tree once in mozilla-central.
24044d0
to
21ec035
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the approach in general and the changes seem correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approach seems reasonable to me, deferring to others for the more specific Gradle changes. Note that there's some docs which probably need updating for these changes (like NDK updates).
Newer version of #6530
There are 3 commits here, mainly as some might be more controversial than others:
appServicesRootDir
rather thanrootDir
; no real functionality changes just a way so gradle works roughly the same in both places.Config
object as m-c. When app-services is in m-c, we end up using theConfig
object from m-c - the app-services version of this object is just for use in app-services so the same gradle code works in both places. Given some comments in the source it appears we maybe used to do that?gradle.hasProperty("mozconfig")
if it needs to do something different based on the location. For now, that means things like disabling the cargo-gradle plugin and changing how uniffi-bindgen is run, etc. The implemented behaviour should be correct in app-services, but might be less so in m-c for now (eg, currently we just disable uniffi-bindgen, whereas ultimately we obviously still need to run it, once I work out how!)