Migrate build scripts to python with single script to orchestrate during make up #23011
+354
−54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinMind
requested review from
a team,
eviljeff and
diox
and removed request for
a team and
eviljeff
KevinMind
commented
Jan 22, 2025
KevinMind
force-pushed
the
sync-host-files
branch
from
f950ffb to
0bfd18e
Compare
…ing make up - Replaced the locale compilation script from a shell script to a Python script (compile_locales.py) for better error handling and parallel processing. - Updated the update_assets target in Makefile-docker to use the new update_assets.py script. - Removed the obsolete compile-mo.sh script. - Introduced sync_host_files.py to streamline dependency updates and asset synchronization.
KevinMind
force-pushed
the
sync-host-files
branch
from
0bfd18e to
ce742fa
Compare
KevinMind
force-pushed
the
sync-host-files
branch
from
3d3ffca to
a911538
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: mozilla/addons#15066
Also fixes the below issue regarding
Fixes: mozilla/addons#15235
Description
Context
This changes makes sure that the state of the host file system matches the state of the container before running the containers.
This enables simplifying the volumes we use to a single volume from the host to the /data/olympia directory.
On the flip side, the docker build uses the exact same scripts to execute build logic during a build. That is how we guarantee files match in and out of the container.
Testing
Run the container in production mode.
I would have suggested a content hashing test to verify the site-static directory from the built image and the one from make up are identical, but django
staticfiles.jsonis non-deterministically created.. changes the order of the json attributes. I think now it is enough that literally the same command is run.Checklist
#ISSUENUMat the top of your PR to an existing open issue in the mozilla/addons repository.