-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fonts #853
Add fonts #853
Conversation
muffinresearch
commented
Jul 29, 2016
•
edited
Loading
edited
- Add Fira Sans webfonts (woff2, woff and otf) we don't need eot since we won't be worrying older IE versions.
- Fix clean script to remove everything from dist except the .gitkeep file.
I see some binary files that appear to be unused in the |
test: /\.mp4$/, | ||
loader: 'url?limit=10000&mimetype=video/mp4', | ||
}], | ||
loaders: [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks similar to what's in the karma config. Is there an easy way to combine them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, that's a separate yak to shave issue is filed here: https://github.com/mozilla/addons-frontend/issues/353
I don't know much about fonts but r+wc :) |
I'll leave the extra fonts for now, it's early days so we don't really know what we might need. Also there's a possibility of using an entirely different font, in which case all this will be replaced. However, I'm making mixins in another branch to make any replacement of font-families painless. |