Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fonts #853

Merged
merged 1 commit into from
Jul 29, 2016
Merged

Add fonts #853

merged 1 commit into from
Jul 29, 2016

Conversation

muffinresearch
Copy link
Contributor

@muffinresearch muffinresearch commented Jul 29, 2016

  • Add Fira Sans webfonts (woff2, woff and otf) we don't need eot since we won't be worrying older IE versions.
  • Fix clean script to remove everything from dist except the .gitkeep file.

@muffinresearch muffinresearch changed the title Add fonts WiP Add fonts Jul 29, 2016
@kumar303
Copy link
Contributor

I see some binary files that appear to be unused in the scss, like UltraLightItalic and ExtraBold, etc. Do we still need to include them?

test: /\.mp4$/,
loader: 'url?limit=10000&mimetype=video/mp4',
}],
loaders: [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks similar to what's in the karma config. Is there an easy way to combine them?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, that's a separate yak to shave issue is filed here: https://github.com/mozilla/addons-frontend/issues/353

@kumar303
Copy link
Contributor

I don't know much about fonts but r+wc :)

@muffinresearch
Copy link
Contributor Author

muffinresearch commented Jul 29, 2016

I see some binary files that appear to be unused in the scss, like UltraLightItalic and ExtraBold, etc. Do we still need to include them?

I'll leave the extra fonts for now, it's early days so we don't really know what we might need. Also there's a possibility of using an entirely different font, in which case all this will be replaced.

However, I'm making mixins in another branch to make any replacement of font-families painless.

@muffinresearch muffinresearch merged commit c43f888 into mozilla:master Jul 29, 2016
@muffinresearch muffinresearch deleted the fonts branch July 29, 2016 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants