Tweak the local logging behavior to use the exception explicitly provided #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomrittervg
force-pushed
the
2024-09-05-logging-tweak
branch
from
de221de to
7d2f4f9
Compare
tomrittervg
force-pushed
the
2024-09-05-logging-tweak
branch
from
7d2f4f9 to
6fb0299
Compare
|
Okay, aborting this change because this only works in 3.10+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think this would affect #378 but I don't have any better ideas. It seems like it'd be possible for a snetry log to go first, raise an exception, and then this (old) code to do the wrong thing so making it explicit should be better?