avoid mapping memory and comparing joints with zero variables #519
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
getJointPositions()
on a joint model with zero variables is buggy on the MoveIt side. It will return a meaningless value most of the time, but can access out of bounds memory in some edge cases (fixed joints at the end of a robot model).This had been okay until now because
RobotState
had big chunk of memory accessed via raw pointers, so out of bounds memory access was silently happening.RobotState
now usesstd::vector
internally for data allocation, which means that any out-of-bounds access will now trigger an exception.We should fix the
getJointPositions()
(and others) behavior in MoveIt (follow up PR), but this change won't hurt anyway because there is no need to Eigen::Map and compare zero-sized memory.