fixup! Reset joint values in scene diff for execution (#498) #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## ros2 #504 +/- ##
==========================================
+ Coverage 42.41% 42.42% +0.01%
==========================================
Files 83 83
Lines 8046 8045 -1
==========================================
Hits 3412 3412
+ Misses 4634 4633 -1
☔ View full report in Codecov by Sentry. |
|
Thanks @rhaschke! |
sjahr
approved these changes
Nov 9, 2023
rhaschke
added a commit
that referenced
this pull request
Mar 7, 2024
Joints are handled in trajectories. Scene diffs should not modify joints during execution. Fixes #353.
rhaschke
added a commit
to ubi-agni/moveit_task_constructor
that referenced
this pull request
Mar 8, 2024
Joints are handled in trajectories. Scene diffs should not modify joints during execution. Fixes moveit#353. Alternative to moveit#504. The previous solution, to always clear the joint states during message generation, broke the visualization in rviz.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #353 (comment).