Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DON'T MERGE] Test if #355 causes CI failure #503

Closed
wants to merge 1 commit into from

Conversation

sjahr
Copy link
Contributor

@sjahr sjahr commented Nov 3, 2023

This reverts commit 94d6514.

…use when executing the planned trajectory (moveit#355)"

This reverts commit 94d6514.
Copy link

codecov bot commented Nov 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (94d6514) 42.46% compared to head (f58bb89) 42.41%.

Additional details and impacted files
@@            Coverage Diff             @@
##             ros2     #503      +/-   ##
==========================================
- Coverage   42.46%   42.41%   -0.04%     
==========================================
  Files          83       83              
  Lines        8053     8043      -10     
==========================================
- Hits         3419     3411       -8     
+ Misses       4634     4632       -2     
Files Coverage Δ
core/include/moveit/task_constructor/stage.h 91.67% <ø> (-1.01%) ⬇️
core/src/container.cpp 73.10% <ø> (-0.06%) ⬇️
core/src/stage.cpp 81.43% <ø> (-0.03%) ⬇️
core/src/storage.cpp 49.69% <ø> (+0.62%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rhaschke
Copy link
Contributor

rhaschke commented Nov 3, 2023

Looks like #355 is the culprit!

@sjahr
Copy link
Contributor Author

sjahr commented Nov 3, 2023

Mhm, I cannot reproduce it locally and it seems like running the CI job on the ROS 2 branch manually again led to success: https://github.com/ros-planning/moveit_task_constructor/actions/runs/6745669013

@sjahr sjahr closed this Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants