Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify formatting code with https://github.com/fmtlib #499

Merged
merged 2 commits into from
May 25, 2024

Conversation

rhaschke
Copy link
Contributor

No description provided.

@rhaschke rhaschke force-pushed the libfmt branch 2 times, most recently from 4202550 to e752284 Compare October 26, 2023 15:29
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Attention: 46 lines in your changes are missing coverage. Please review.

Comparison is base (a905572) 59.00% compared to head (e752284) 59.04%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #499      +/-   ##
==========================================
+ Coverage   59.00%   59.04%   +0.04%     
==========================================
  Files          90       90              
  Lines        8485     8471      -14     
==========================================
- Hits         5006     5001       -5     
+ Misses       3479     3470       -9     
Files Coverage Δ
core/include/moveit/task_constructor/stage_p.h 93.66% <100.00%> (ø)
core/src/properties.cpp 85.81% <100.00%> (ø)
core/src/stages/fix_collision_objects.cpp 8.46% <ø> (ø)
core/src/stages/simple_grasp.cpp 67.09% <ø> (ø)
...abilities/src/execute_task_solution_capability.cpp 78.58% <0.00%> (ø)
core/src/stages/modify_planning_scene.cpp 82.50% <0.00%> (ø)
core/src/stages/compute_ik.cpp 81.09% <0.00%> (ø)
core/src/stages/connect.cpp 88.62% <0.00%> (ø)
...ation/visualization_tools/src/display_solution.cpp 0.00% <0.00%> (ø)
core/src/container.cpp 85.72% <84.22%> (-0.19%) ⬇️
... and 2 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rhaschke
Copy link
Contributor Author

Bionic doesn't ship libfmt yet... 😞

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 55.30303% with 59 lines in your changes are missing coverage. Please review.

Project coverage is 56.31%. Comparing base (6b0f2c8) to head (f4bef2d).
Report is 12 commits behind head on master.

Files Patch % Lines
core/src/stage.cpp 56.10% 18 Missing ⚠️
core/src/container.cpp 77.05% 14 Missing ⚠️
core/src/cost_terms.cpp 0.00% 13 Missing ⚠️
...ation/visualization_tools/src/display_solution.cpp 0.00% 4 Missing ⚠️
...abilities/src/execute_task_solution_capability.cpp 0.00% 2 Missing ⚠️
core/src/stages/compute_ik.cpp 0.00% 2 Missing ⚠️
core/src/stages/connect.cpp 0.00% 2 Missing ⚠️
core/src/stages/modify_planning_scene.cpp 0.00% 2 Missing ⚠️
core/src/properties.cpp 66.67% 1 Missing ⚠️
core/src/stages/fix_collision_objects.cpp 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #499      +/-   ##
==========================================
- Coverage   58.82%   56.31%   -2.51%     
==========================================
  Files          91      130      +39     
  Lines        8623    10742    +2119     
  Branches        0      945     +945     
==========================================
+ Hits         5072     6048     +976     
- Misses       3551     4647    +1096     
- Partials        0       47      +47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rhaschke rhaschke marked this pull request as ready for review May 25, 2024 17:11
@rhaschke rhaschke merged commit 7666f73 into moveit:master May 25, 2024
6 checks passed
@rhaschke rhaschke deleted the libfmt branch May 25, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants