Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setting for disposable time between transfers #153

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

MichaelKutzner
Copy link
Contributor

This adds an option to increase the time between transfers by a fixed duration. This setting can be used, if passengers want some time for orientation or to compensate small delays.

This adds an option to increase the time between transfers by a fixed
duration. This setting can be used, if passengers want some time for
orientation or to compensate small delays.
@felixguendling
Copy link
Member

please rename disposable -> additional

the word disposable seems not like a good fit
https://www.thesaurus.com/browse/disposable

@MichaelKutzner
Copy link
Contributor Author

Any suggestions for a better name? Thank you for the fast reply
I'm also not sure, if the duration for the footpath should include this duration. Or if it should be split, e.g. FOOTPATH (duration=X, additional_time=Y)

@felixguendling
Copy link
Member

I guess the user expects that (footpath time + additional time) < (departure time - arrival time)

At least I would expect that.

@MichaelKutzner
Copy link
Contributor Author

That was my intention, to make the footpath duration and additional time more obvious. But as I wrote, I'm not sure what format might be good to avoid possible confusion. I think, it might also depends on how the feature will be used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants