Motechupgrade (#4) #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Java to Java 8, Datanucleus to 4.0 , Spring to Core -- In Progress * TODO Upgrade at 6 places -- mostly with security * Spring test libraries upgrade - In Progress * Datanucleus 4.1.0 * Spring 4.3 -- tests passed. checking PIT * Fixed Null pointer * Fixed server start issues. Fixed issues w.r.t OSGI update * SPring-JMS and integaration in Progress and few IT test cases commendted * Fixed some of the failing tests * removed problematic dependency * Fixing PIT and OSGI/felix related changes * Fixing PIT and OSGI/felix related changes * lang3 versions * removing gemini mock ( added unintentionally dhiraj) * Changed to ERROR mode * Changing all xsd's inspring 3 to Spring 4. Fixing javax.persistenec error Fixing Event errors Fixing OSGi upgrade issues Upgrade commons-loggin ! osgi-web-util errors * Guava, Itextpdf, paranemer - Inprogress * Guava, jsr305 , * Mysql * GSON errors and postgresql * Removed fixed TODO's * Replaced depricated DefaultAnnotationHandlerMapping with RequestMappingHandlerMapping in bootstrap-servlet.xml * Fixed ResetControllerTest * Fixed MdsRestControllerTest * Fixed a failing test in BootstrapControllerTest * Added Dependency for openid4javaNoDeps. * Added Active MQ Broker and Client which replaced active MQ Broker used earlier. * Updated felix version * Fixed dependency issue for gemini blueprint * Added custom bundle of spring web and used in motech project.
dannyroberts
approved these changes
Aug 29, 2018
| @@ -23,19 +23,19 @@ public void setResetForm(ResetForm resetForm) { | |||
| this.resetForm = resetForm; | |||
| } | |||
|
|
|||
| public boolean isResetSucceed() { | |||
| public boolean isIsResetSucceed() { | |||
There was a problem hiding this comment.
Did you mean to make this change? isResetSucceed makes more sense to me, so wondering whether it maybe got changed along with setIsResetSucceed below by mistake.
There was a problem hiding this comment.
will change it back -- looks like this was tried along with other changes to fix PIT's - but eventually not needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Java to Java 8, Datanucleus to 4.0 , Spring to Core -- In Progress
TODO Upgrade at 6 places -- mostly with security
Spring test libraries upgrade - In Progress
Datanucleus 4.1.0
Spring 4.3 -- tests passed. checking PIT
Fixed Null pointer
Fixed server start issues.
Fixed issues w.r.t OSGI update
SPring-JMS and integaration in Progress and few IT test cases commendted
Fixed some of the failing tests
removed problematic dependency
Fixing PIT and OSGI/felix related changes
Fixing PIT and OSGI/felix related changes
lang3 versions
removing gemini mock ( added unintentionally dhiraj)
Changed to ERROR mode
Changing all xsd's inspring 3 to Spring 4.
Fixing javax.persistenec error
Fixing Event errors
Fixing OSGi upgrade issues
Upgrade commons-loggin !
osgi-web-util errors
Guava, Itextpdf, paranemer - Inprogress
Guava, jsr305 ,
Mysql
GSON errors and postgresql
Removed fixed TODO's
Replaced depricated DefaultAnnotationHandlerMapping with RequestMappingHandlerMapping in bootstrap-servlet.xml
Fixed ResetControllerTest
Fixed MdsRestControllerTest
Fixed a failing test in BootstrapControllerTest
Added Dependency for openid4javaNoDeps.
Added Active MQ Broker and Client which replaced active MQ Broker used earlier.
Updated felix version
Fixed dependency issue for gemini blueprint
Added custom bundle of spring web and used in motech project.