Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add __len__ for pool #510

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add __len__ for pool #510

wants to merge 2 commits into from

Conversation

shizacat
Copy link

@shizacat shizacat commented Dec 5, 2022

It added the property len for class Pool.
Sometimes need to know how many items have stored into Pool.

mosquito
mosquito previously approved these changes Dec 5, 2022
View reviewed changes
Copy link
Owner

@mosquito mosquito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mosquito
Copy link
Owner

mosquito commented Dec 5, 2022

@shizacat I'm on vacation, is it possible to merge it on the next week?

@shizacat
Copy link
Author

shizacat commented Dec 6, 2022

@mosquito Yes, of course

@Lancetnik
Copy link
Contributor

Can we merge it?

@mosquito
Copy link
Owner

Now the PR must be rebased before

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@decaz decaz decaz approved these changes

@Alviner Alviner Alviner approved these changes

@mosquito mosquito mosquito left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shizacat @mosquito @Lancetnik @decaz @Alviner