This repository has been archived by the owner on Feb 11, 2020. It is now read-only.
fix: options missing when called storage backend #630
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when you call the example redis implementations, I believe the options won't get passed through. You can easily miss this locally, as redis for example is just calling its defaults. However, setting password is silent fail.
The expectation from the redis example is that all options from the ascoltatore object gets passed down.
Though this fix fixed the redis problem I would maybe rather recommend modernisation around inheritance and option passing. But I know you know what best to do. I offer my help, as I am currently doing a lot with MQTT in a my day job.
Example: