Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: subscriptions not read correctly on startup #100

Merged
merged 1 commit into from
Jun 13, 2022
Merged

fix: subscriptions not read correctly on startup #100

merged 1 commit into from
Jun 13, 2022

Conversation

seriousme
Copy link
Contributor

This PR adds proper decoding to subscriptions to resolve the issue described in #98.

Kind regards,
Hans

robertsLando
robertsLando approved these changes Jun 13, 2022
View reviewed changes
Copy link
Member

@robertsLando robertsLando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strange this hasn't been picked up by any test 🤔 LGTM

@robertsLando robertsLando merged commit 8448baf into moscajs:master Jun 13, 2022
@seriousme seriousme deleted the fix-qos-1 branch June 13, 2022 16:15
@seriousme
Copy link
Contributor Author

strange this hasn't been picked up by any test 🤔 LGTM

we might want to:

  • add an explicit test to ensure reload on startup works
  • refactor the reload code to make it more readable ;-)

I was a bit hesitant to touch this part of the code due to its complexity ;-)

@robertsLando
Copy link
Member

Let's keep it as it is for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertsLando robertsLando robertsLando approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seriousme @robertsLando