Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update halmos tests for new halmos version #143

Merged
merged 5 commits into from
Sep 26, 2024

Conversation

daejunpark
Copy link
Contributor

@daejunpark daejunpark commented Sep 25, 2024

This PR updates the existing halmos tests to accommodate changes in the latest version of halmos.

Changes:

  • Replaced the --symbolic-storage flag with the enableSymbolicStorage(address) cheatcode, as the former has been deprecated in the new halmos version.
  • Removed --solver-parallel, as it is now enabled by default.
  • Removed --test-parallel, which will be deprecated in the next release in preparation for portfolio solving.

The `enableSymbolicStorage(address)` cheatcode is used instead of the `--symbolic-storage` option, which will be deprecated in the next release of halmos.
- `--symbolic-storage` is deprecated; use the `enableSymbolicStorage(address)` cheatcode instead.
- `--solver-parallel` is deprecated; use `--solver-threads N` instead, where `N` defaults to the number of cores.
@daejunpark daejunpark mentioned this pull request Sep 25, 2024
17 tasks
Copy link
Collaborator

@MathisGD MathisGD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot!

@MathisGD MathisGD merged commit f1197b3 into morpho-org:main Sep 26, 2024
2 of 4 checks passed
@daejunpark daejunpark deleted the ci/halmos branch September 26, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants