Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DLL loops to address(0) #141

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

DLL loops to address(0) #141

wants to merge 18 commits into from

Conversation

QGarchery
Copy link
Collaborator

@QGarchery QGarchery commented Jul 10, 2024 •
edited
Loading

This PR:

@QGarchery QGarchery self-assigned this Jul 10, 2024
@QGarchery QGarchery changed the title Loop DLL DLL loops to address(0) Jul 11, 2024
@QGarchery QGarchery linked an issue Jul 11, 2024 that may be closed by this pull request
DLL: use address(0) instead of head and tail #85
Open
@QGarchery QGarchery marked this pull request as ready for review July 11, 2024 11:51
Rubilmax
Rubilmax previously approved these changes Aug 8, 2024
View reviewed changes
Copy link
Collaborator

@Rubilmax Rubilmax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so much simpler

src/DoubleLinkedList.sol Outdated Show resolved Hide resolved
src/DoubleLinkedList.sol Outdated Show resolved Hide resolved
src/DoubleLinkedList.sol Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rubilmax Rubilmax Rubilmax approved these changes

@adhusson adhusson Awaiting requested review from adhusson

@MerlinEgalite MerlinEgalite Awaiting requested review from MerlinEgalite

@MathisGD MathisGD Awaiting requested review from MathisGD

@Jean-Grimal Jean-Grimal Awaiting requested review from Jean-Grimal

At least 2 approving reviews are required to merge this pull request.

Assignees

@QGarchery QGarchery

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DLL: use address(0) instead of head and tail
2 participants
@QGarchery @Rubilmax