Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add formatting in CI #21

Merged
merged 4 commits into from
Oct 13, 2023
Merged

Add formatting in CI #21

merged 4 commits into from
Oct 13, 2023

Conversation

MerlinEgalite
Copy link
Contributor

@MerlinEgalite MerlinEgalite commented Oct 12, 2023 •
edited
Loading

Fixes #20

@MerlinEgalite MerlinEgalite changed the title ci: add formatter Add formatting in CI Oct 12, 2023
@MerlinEgalite MerlinEgalite requested review from QGarchery, MathisGD, a team, Rubilmax and Jean-Grimal and removed request for a team October 12, 2023 11:46
@MerlinEgalite MerlinEgalite linked an issue Oct 12, 2023 that may be closed by this pull request
Check formatting in CI #20
Closed
@MerlinEgalite MerlinEgalite marked this pull request as ready for review October 12, 2023 11:46
QGarchery
QGarchery approved these changes Oct 12, 2023
View reviewed changes
.github/workflows/formatting.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
MathisGD
MathisGD reviewed Oct 12, 2023
View reviewed changes
.github/workflows/foundry.yml Show resolved Hide resolved
.github/workflows/test.yml
@@ -1,13 +1,17 @@
name: test
name: Foundry
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand this change

Suggested change
name: Foundry
name: test

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#21 (comment)

MathisGD
MathisGD approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@MathisGD MathisGD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving anywa

@MathisGD MathisGD merged commit 0fcd315 into feat/chainlink-vault-decimals Oct 13, 2023
2 checks passed
@MathisGD MathisGD deleted the ci/formatter branch October 13, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QGarchery QGarchery QGarchery approved these changes

@Jean-Grimal Jean-Grimal Jean-Grimal approved these changes

@MathisGD MathisGD MathisGD approved these changes

@Rubilmax Rubilmax Awaiting requested review from Rubilmax Rubilmax was automatically assigned from morpho-labs/onchain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check formatting in CI
4 participants
@MerlinEgalite @QGarchery @MathisGD @Jean-Grimal