Chainlink ERC4626: allow to pass the vault decimals directly #19
Conversation
QGarchery
requested review from
Rubilmax,
MerlinEgalite and
Jean-Grimal
and removed request for
a team
There was a problem hiding this comment.
Well in fact I'm still not convinced about this.
EDIT: I may be convinced but I feel that the solution is incomplete.
Correct License
Add formatting in CI
There was a problem hiding this comment.
Just commented that when you pushed lol: #19 (comment)
I'm not a fan of sample tbh..
Why not ? I feel like it fits pretty well: we take a sample, price it, scale it down to get the generic price |
I have the feeling that a sample is something that can change from the definition (else why taking a sample) while here study the evaluate the value of the same amount of shares each time. So to me it feels more like a reference. I'm approving as I don't think it's a big deal |
src/ChainlinkOracle.sol
Outdated
| ); | ||
| } | ||
|
|
||
| /* PRICE */ | ||
|
|
||
| /// @inheritdoc IOracle | ||
| function price() external view returns (uint256) { | ||
| return (VAULT.getAssets(10 ** VAULT_PRECISION) * BASE_FEED_1.getPrice() * BASE_FEED_2.getPrice() * SCALE_FACTOR) | ||
| uint256 sample = 10 ** CONVERSION_SAMPLE_DECIMALS; |
There was a problem hiding this comment.
perhaps it could be an immutable as well?
There was a problem hiding this comment.
#26, saves 300 gas apparently
To fix that #7 (comment)