Refactor oracles #70
Merged
Refactor oracles #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MerlinEgalite
requested review from
pakim249CAL,
Jean-Grimal,
makcandrov and
Rubilmax
Closed
pakim249CAL
reviewed
Aug 20, 2023
pakim249CAL
reviewed
Aug 20, 2023
pakim249CAL
reviewed
Aug 20, 2023
pakim249CAL
reviewed
Aug 20, 2023
makcandrov
approved these changes
Aug 21, 2023
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
pakim249CAL
approved these changes
Aug 21, 2023
…-periphery into refactor/oracles-base
Signed-off-by: Merlin Egalite <[email protected]>
refactor(oracle): remove redundant overrides
Rubilmax
reviewed
Aug 21, 2023
Co-authored-by: Romain Milon <[email protected]> Signed-off-by: Merlin Egalite <[email protected]>
Closed
Jean-Grimal
approved these changes
Aug 21, 2023
Use immutables in `BaseOracle` directly
Refactor oracles 2
MerlinEgalite
requested review from
Jean-Grimal,
makcandrov,
pakim249CAL and
Rubilmax
Rubilmax
approved these changes
Aug 21, 2023
Jean-Grimal
approved these changes
Aug 21, 2023
Co-authored-by: Romain Milon <[email protected]> Signed-off-by: Merlin Egalite <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #67
Open to suggestions. But it abstract the whole complexity to
BaseOracleand the adapters