Run StEth fork test by default #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adhusson
requested review from
MathisGD,
Rubilmax,
QGarchery,
MerlinEgalite and
Jean-Grimal
QGarchery
reviewed
Oct 28, 2024
MathisGD
reviewed
Oct 28, 2024
|
Not allowed to merge but closing #460. |
QGarchery
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
forge test, the parent contract of fork tests namedForkTestsets the chain id to 1 by default in itssetUpfuncton. All fork tests except one thus run on Ethereum.EthereumStEthBundlerForkTestdoes not, because it skipsForkTest'ssetUpif the chain id is not 1, and all its tests are skipped if the chain id is not 1.This PR makes the tests of
EthereumStEthBundlerForkTestrun by default.