Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: fork setup #171

Merged
merged 8 commits into from
Sep 15, 2023
Merged

refactor: fork setup #171

merged 8 commits into from
Sep 15, 2023

Conversation

Jean-Grimal
Copy link
Contributor

No description provided.

@Jean-Grimal Jean-Grimal changed the base branch from main to fix/stop-fuzz-addresses September 14, 2023 14:55
Rubilmax
Rubilmax reviewed Sep 14, 2023
View reviewed changes
Copy link
Collaborator

@Rubilmax Rubilmax left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cleanest refactoring of all your refactorings so far 👏

config/ConfiguredEthereumMainnet.sol Outdated Show resolved Hide resolved
config/ConfiguredEthereumMainnet.sol Outdated Show resolved Hide resolved
@MerlinEgalite
Copy link
Contributor

The CI is failing @Jean-Grimal

@Jean-Grimal
Copy link
Contributor Author

The CI is failing @Jean-Grimal

Yes, Here is the log : (code: -32000, message: execution aborted (timeout = 10s), data: None))
I think the error comes from the RPC.
I am going to reduce the runs of the Ethereum tests because they take too long

@Rubilmax
Copy link
Collaborator

Rubilmax commented Sep 15, 2023 •
edited
Loading

Even local tests (slow) are too long: 23m

I'd suggest:

  • divide by 3 local tests (slow)
  • divide by 5 Ethereum tests (slow)
  • divide by 10 Ethereum tests (fast)

And see if it's not fast enough then divide again

Base automatically changed from fix/stop-fuzz-addresses to main September 15, 2023 13:06
@MerlinEgalite MerlinEgalite merged commit cb92bb8 into main Sep 15, 2023
8 checks passed
@MerlinEgalite MerlinEgalite deleted the refactor/fork-config branch September 15, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MerlinEgalite MerlinEgalite MerlinEgalite approved these changes

@Rubilmax Rubilmax Rubilmax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jean-Grimal @MerlinEgalite @Rubilmax