Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WstEthBundler tests #149

Merged
merged 20 commits into from
Sep 15, 2023
Merged

WstEthBundler tests #149

merged 20 commits into from
Sep 15, 2023

Conversation

Jean-Grimal
Copy link
Contributor

No description provided.

Base automatically changed from fix/StEthBundler to main September 12, 2023 13:12
@Jean-Grimal
Copy link
Contributor Author

We finally chose to remove the transferSharesFrom function (even if it solved the rounding issue on StEth transfers, and then allowed to transfer one's whole balance) because it was not Permit2 compliant.
We also chose to not handle at all the rounding problems that might happen on transfers or on wrap/unwrap function. Then, 1 Wei might stay on the bundler.

Rubilmax
Rubilmax reviewed Sep 13, 2023
View reviewed changes
config/Configured.sol Outdated Show resolved Hide resolved
@Jean-Grimal Jean-Grimal changed the base branch from main to refactor/fork-config September 14, 2023 13:33
Base automatically changed from refactor/fork-config to main September 15, 2023 13:11
@Rubilmax Rubilmax merged commit 35f7e1e into main Sep 15, 2023
8 checks passed
@Rubilmax Rubilmax deleted the feat/add-StEthBundler-tests branch September 15, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MerlinEgalite MerlinEgalite MerlinEgalite approved these changes

@Rubilmax Rubilmax Rubilmax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jean-Grimal @Rubilmax @MerlinEgalite