feat(oracle): add univ3 and chainlink adapters #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Rubilmax
commented
Aug 8, 2023
Rubilmax
commented
- Fixes Migrate oracles Uniswap and Chainlink #11
Rubilmax
requested review from
QGarchery,
MerlinEgalite,
pakim249CAL,
MathisGD,
Jean-Grimal and
makcandrov
pakim249CAL
reviewed
Aug 8, 2023
Jean-Grimal
reviewed
Aug 8, 2023
pakim249CAL
approved these changes
Aug 8, 2023
Jean-Grimal
approved these changes
Aug 8, 2023
makcandrov
approved these changes
Aug 8, 2023
MerlinEgalite
requested changes
Aug 8, 2023
MerlinEgalite
approved these changes
Aug 9, 2023
julien-devatom
previously requested changes
Aug 19, 2023
MerlinEgalite
force-pushed
the
feat/oracles
branch
from
8fc5ae3
to
721e0ff
Compare
MerlinEgalite
requested review from
MerlinEgalite,
pakim249CAL,
julien-devatom,
makcandrov and
Jean-Grimal
pakim249CAL
reviewed
Aug 20, 2023
| @@ -6,6 +6,7 @@ import {IChainlinkAggregatorV3} from "../adapters/interfaces/IChainlinkAggregato | |||
| library ChainlinkAggregatorV3Lib { | |||
| function price(IChainlinkAggregatorV3 aggregator) internal view returns (uint256) { | |||
| (, int256 answer,,,) = aggregator.latestRoundData(); | |||
| require(answer > 0, "ChainlinkAggregatorV3Lib: price is negative"); | |||
There was a problem hiding this comment.
That makes me think that we may not want to revert on 0, wdyt?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.