Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply curie upgrade #13

Merged
merged 7 commits into from
Jul 4, 2024
Merged

Apply curie upgrade #13

merged 7 commits into from
Jul 4, 2024

Conversation

chengwenxi
Copy link
Collaborator

Description

[PR description]

Issue Link

[link issue here]

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Contents

  • [item]

Rationale

[design decisions and extended information]

How Has This Been Tested?

[explanation]


How to fill a PR description

Please give a concise description of your PR.

The target readers could be future developers, reviewers, and auditors. By reading your description, they should easily understand the changes proposed in this pull request.

MUST: Reference the issue to resolve

Single responsability

Is RECOMMENDED to create single responsibility commits, but not mandatory.

Anyway, you MUST enumerate the changes in a unitary way, e.g.

This PR contains:
- Cleanup of xxxx, yyyy
- Changed xxxx to yyyy in order to bla bla
- Added xxxx function to ...
- Refactored ....

Design choices

RECOMMENDED to:

  • What types of design choices did you face?
  • What decisions you have made?
  • Any valuable information that could help reviewers to think critically

Copy link

@Voidkai Voidkai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in comment

zkevm-circuits/src/evm_circuit/util/common_gadget/curie.rs Outdated Show resolved Hide resolved
Copy link

@Voidkai Voidkai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

batch constraint

@chengwenxi chengwenxi merged commit e8ea286 into develop Jul 4, 2024
15 of 18 checks passed
@chengwenxi chengwenxi deleted the upgrade branch July 4, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants